Slight refactoring

hpi-swa · Jan 10, 2024 · f6d4a36 · f6d4a36
1 parent 554e14e
commit f6d4a36
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/Sandblocks-Smalltalk/SBVariantProxy.class.st b/packages/Sandblocks-Smalltalk/SBVariantProxy.class.st
@@ -98,10 +98,10 @@ SBVariantProxy >> updateOriginalWithOwnValues [
 	| variantThatNeedsChanging |
 	variantThatNeedsChanging := self containedMethod detectVariant: original.
 
-	variantThatNeedsChanging ifNil: [self delete. ^ self].
+	variantThatNeedsChanging ifNil: [^self delete].
 
 	original replaceBy: (original := self firstSubmorph copyBlock).
-	original isVariant ifFalse: [self delete. ^ self].
+	original isVariant ifFalse: [^ self delete].
 
 	variantThatNeedsChanging replaceValuesFrom: original copyBlock.
 	self sandblockEditor markChanged: self containedMethod
@@ -112,8 +112,9 @@ SBVariantProxy >> updateSelfAfterMethodUpdate: newMethod [
 
 	| variantThatMaybeChanged |
 	variantThatMaybeChanged := newMethod detectVariant: original.
+	containedMethod := newMethod.
 
-	variantThatMaybeChanged ifNil: [self delete. ^ self].
+	variantThatMaybeChanged ifNil: [^self delete].
 
 	(variantThatMaybeChanged sourceString ~= self firstSubmorph sourceString)
 		ifTrue: [