N21-2309 Fix validation and add support for unknown schulconnex group…

… roles (#5367)

apps/server/src/infra/schulconnex-client/response/schulconnex-gruppenzugehoerigkeit-response.ts

@@ -1,9 +1,8 @@
-import { IsArray, IsEnum, IsOptional } from 'class-validator';
-import { SchulconnexGroupRole } from './schulconnex-group-role';
+import { IsArray, IsOptional, IsString } from 'class-validator';
 
 export class SchulconnexGruppenzugehoerigkeitResponse {
 	@IsOptional()
 	@IsArray()
-	@IsEnum(SchulconnexGroupRole, { each: true })
-	rollen?: SchulconnexGroupRole[];
+	@IsString({ each: true })
+	rollen?: string[];
 }

apps/server/src/infra/schulconnex-client/response/schulconnex-sonstige-gruppenzugehoerige-response.ts

@@ -1,12 +1,11 @@
-import { IsArray, IsEnum, IsOptional, IsString } from 'class-validator';
-import { SchulconnexGroupRole } from './schulconnex-group-role';
+import { IsArray, IsOptional, IsString } from 'class-validator';
 
 export class SchulconnexSonstigeGruppenzugehoerigeResponse {
 	@IsString()
 	ktid!: string;
 
 	@IsOptional()
 	@IsArray()
-	@IsEnum(SchulconnexGroupRole, { each: true })
-	rollen?: SchulconnexGroupRole[];
+	@IsString({ each: true })
+	rollen?: string[];
 }

apps/server/src/modules/provisioning/strategy/sanis/schulconnex-response-mapper.ts

@@ -34,7 +34,7 @@ const RoleMapping: Record<SchulconnexRole, RoleName> = {
 	[SchulconnexRole.ORGADMIN]: RoleName.ADMINISTRATOR,
 };
 
-const GroupRoleMapping: Partial<Record<SchulconnexGroupRole, RoleName>> = {
+const GroupRoleMapping: Partial<Record<SchulconnexGroupRole | string, RoleName>> = {
 	[SchulconnexGroupRole.TEACHER]: RoleName.TEACHER,
 	[SchulconnexGroupRole.STUDENT]: RoleName.STUDENT,
 };
@@ -146,7 +146,7 @@ export class SchulconnexResponseMapper {
 			otherUsers = group.sonstige_gruppenzugehoerige
 				? group.sonstige_gruppenzugehoerige
 						.map((relation): ExternalGroupUserDto | null => this.mapToExternalGroupUser(relation))
-						.filter((otherUser: ExternalGroupUserDto | null) => otherUser !== null)
+						.filter((otherUser: ExternalGroupUserDto | null): otherUser is ExternalGroupUserDto => otherUser !== null)
 				: [];
 		}