EntityPickupItemEvent #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpfxd
reviewed
Oct 7, 2023
|
I've cleaned the patch up a bit and implemented the event in places where it was missing (picking up arrows and insentient mobs). I've not had the time to test this in-game. If anyone has tested and can confirm this is working as it should, please share results :) |
uRyanxD
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
I tested the event with a Zombie and myself (player entity) and it worked perfectly for me.
If anyone else is going to test the event, here is a command to generate a mob that takes the item (without needing luck):
/summon Zombie ~ ~1 ~ {CanPickUpLoot:1b}
Thanks ApplePies for sending me the command.
uRyanxD
reviewed
Oct 7, 2023
hpfxd
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.