-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes about ignored paths (related to hotwired/turbo#1070) #152
base: main
Are you sure you want to change the base?
Add notes about ignored paths (related to hotwired/turbo#1070) #152
Conversation
9f851c2
to
ff6e12d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this.
However, paths ending in .htm
, .html
, .xhtml
, and .php
, are handled by Turbo. Also, you can include a .
in the path, but you must make sure that the path ends with a /
, like https://example.com/users/jason.json/
.
Please confirm the following updated understanding: A
|
Exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's correct! I've just a minor comment
|
||
## Ignored Paths | ||
|
||
Paths with a `.` in the last level of a path/URL will not be handled by Turbo unless they end in a file extension `.htm`, `.html`, `.xhtml`, or `.php`. Turbo will ignore forms and links that target these paths. For example, the following forms would be ignored: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps here we could also explicitly say that if the URL ends in /
it will be handled by Turbo. As it is now, if you don't notice the small detail of the final slash you wouldn't notice it. This would allow to put only 4 examples, 2 for those that are handled and 2 for those that aren't. Perhaps giving 4 examples for each case might be a bit excessive?
Please see hotwired/turbo#1070 for more info.
This reflects currently released behavior, so this is currently relevant despite of what changes may be in the pipeline.
cc @seanpdoyle