Replace reference to Skypack with jsDelivr #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skypack fails to compile packages that use private class fields, even though they are supported by all major browsers and node. Ref. skypackjs/skypack-cdn#308 skypackjs/skypack-cdn#222 skypackjs/skypack-cdn#351 skypackjs/skypack-cdn#354
seanpdoyle
reviewed
Sep 22, 2023
|
|
||
| ```html | ||
| <head> | ||
| <script type="module" src="https://cdn.jsdelivr.net/npm/@hotwired/turbo@latest/dist/turbo.es2017-esm.min.js"></script> |
There was a problem hiding this comment.
Would encouraging consumers to use ga.jspm.io be appropriate?
When I execute bin/importmap pin @hotwired/turbo@latest in a Rails project using Importmaps, it adds the following entry to config/importmap.rb
pin "@hotwired/turbo", to: "https://ga.jspm.io/npm:@hotwired/turbo@7.3.0/dist/turbo.es2017-esm.js"There was a problem hiding this comment.
I don't have any strong preference for any CDN, as long as they work. I think it's ok to mix and match, we're not officially endorsing any.
kevinmcconnell
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Looks good to me 👍
Could also add a link to the package page, as well as showing the script tag example. But seems good either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skypack fails to compile packages that use private class fields, even though they are already supported by all major browsers and node. jsDelivr is convenient in that it provides automatically minified versions of the dist files.
Ref.
https://caniuse.com/mdn-javascript_classes_private_class_fields
skypackjs/skypack-cdn#308
skypackjs/skypack-cdn#222
skypackjs/skypack-cdn#351
skypackjs/skypack-cdn#354