Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream Tag Builder: Support :renderable arguments #569

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/models/turbo/streams/tag_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ def action_all(name, targets, content = nil, method: nil, allow_inferred_renderi
private
def render_template(target, content = nil, allow_inferred_rendering: true, **rendering, &block)
case
when target.respond_to?(:render_in) && content.nil?
target.render_in(@view_context, &block)
when content.respond_to?(:render_in)
content.render_in(@view_context, &block)
when content
Expand Down
32 changes: 32 additions & 0 deletions test/streams/streams_helper_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,32 @@
class TestChannel < ApplicationCable::Channel; end

class Turbo::StreamsHelperTest < ActionView::TestCase
class Component
extend ActiveModel::Naming

def initialize(id:, content:) = (@id, @content = id, content)
def render_in(...) = @content
def to_key = [@id]
end

attr_accessor :formats

test "supports valid :renderable option object with nil content" do
component = Component.new(id: 1, content: "Hello, world")

assert_dom_equal <<~HTML.strip, turbo_stream.update(component)
<turbo-stream action="update" target="streams_helper_test_component_1"><template>Hello, world</template></turbo-stream>
HTML
end

test "supports valid :renderable option object with content" do
component = Component.new(id: 1, content: "Hello, world")

assert_dom_equal <<~HTML.strip, turbo_stream.update(component, "Raw content")
<turbo-stream action="update" target="streams_helper_test_component_1"><template>Raw content</template></turbo-stream>
HTML
end

test "with streamable" do
assert_dom_equal \
%(<turbo-cable-stream-source channel="Turbo::StreamsChannel" signed-stream-name="#{Turbo::StreamsChannel.signed_stream_name("messages")}"></turbo-cable-stream-source>),
Expand Down Expand Up @@ -75,4 +99,12 @@ class Turbo::StreamsHelperTest < ActionView::TestCase
<turbo-stream action="highlight" targets=".a-selector"><template></template></turbo-stream>
HTML
end

test "supports valid :partial option objects" do
message = Message.new(id: 1, content: "Hello, world")

assert_dom_equal <<~HTML.strip, turbo_stream.update(message)
<turbo-stream action="update" target="message_1"><template><p>Hello, world</p></template></turbo-stream>
HTML
end
end
Loading