Fix System Tests in CI environment #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
import-stream-actions
branch
2 times, most recently
from
2a4640e
to
d4abcd8
Compare
zzak
reviewed
Dec 7, 2023
seanpdoyle
force-pushed
the
import-stream-actions
branch
from
d4abcd8
to
bc5a9ce
Compare
seanpdoyle
force-pushed
the
import-stream-actions
branch
4 times, most recently
from
1950a13
to
50e4853
Compare
zzak
approved these changes
Dec 7, 2023
seanpdoyle
force-pushed
the
import-stream-actions
branch
from
50e4853
to
c60056b
Compare
As part of reading from the `RAILS_VERSION` environment set in CI, update the `test/dummy/config/application.rb` to use that environment variable when loading defaults. Fix a test failure when `rails@7.1` by delegating `Message#to_s` to `Message#content` so that tests that broadcast messages without text continue to pass. Also remove an entry with `ruby: "head"`, since we aren't specifying `head` in the `ruby:` key.
Resolve breaking changes introduced in `@hotwired/turbo` that were later fixed in [@hotwired/turbo#4f334da][] (and further resolved in [@hotwired/turbo#7a7c6e2][]). CI is failing because those changes are not available as part of a beta release. Despite the fact that these changes wouldn't be necessary if that release were available, this resolves the broken build pipeline more immediately. [@hotwired/turbo#4f334da]: hotwired/turbo@4f334da [@hotwired/turbo#7a7c6e2]: hotwired/turbo@7a7c6e2
seanpdoyle
force-pushed
the
import-stream-actions
branch
from
c60056b
to
a2adbb1
Compare
|
Thanks for fixing this.
Values used in 'include' do not need to be in the normal matrix. For instance, Ruby Windows has four head builds available in GitHub Actions, EDIT: I just ran CI in my fork with the 'include' ruby head line added back in, passed here. |
With the changes made in the prior commit to pass CI merged, the fact
that Turbo and Turbo Rails somehow have differing references to `Turbo`
and `window.Turbo`.
This commit reverts the test harness change that sets `window.Turbo`,
and instead assigns that value as part of the
`@hotwired/turbo-rails/index` module:
```diff
-import { Turbo } from "@hotwired/turbo-rails"
-
-window.Turbo = Turbo
+import "@hotwired/turbo-rails"
```
seanpdoyle
force-pushed
the
import-stream-actions
branch
from
a2adbb1
to
3011025
Compare
|
@jorgemanrubia are you able to review these changes? |
jorgemanrubia
approved these changes
Dec 14, 2023
|
Thanks. Puma's turbo-rails workflow, which uses both Puma head and turbo-rails head is now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
rails@7.1to the CI Test MatrixAs part of reading from the
RAILS_VERSIONenvironment set in CI,update the
test/dummy/config/application.rbto use that environmentvariable when loading defaults.
Fix a test failure when
rails@7.1by delegatingMessage#to_stoMessage#contentso that tests that broadcast messages without textcontinue to pass.
Also remove an entry with
ruby: "head", since we aren't specifyingheadin theruby:key.Fix System Tests in CI environment
Resolve breaking changes introduced in
@hotwired/turbothat were laterfixed in @hotwired/turbo#4f334da (and further resolved in
@hotwired/turbo#7a7c6e2).
CI is failing because those changes are not available as part of a beta
release. Despite the fact that these changes wouldn't be necessary if
that release were available, this resolves the broken build pipeline
more immediately.
Assign
window.Turboin@hotwired/turbo-rails/indexWith the changes made in the prior commit to pass CI merged, the fact
that Turbo and Turbo Rails somehow have differing references to
Turboand
window.Turbo.This commit reverts the test harness change that sets
window.Turbo,and instead assigns that value as part of the
@hotwired/turbo-rails/indexmodule: