Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsupported ActiveSupport::SafeBuffer being passed to BroadcastStreamJob #525

Closed
wants to merge 1 commit into from
Closed

Fix unsupported ActiveSupport::SafeBuffer being passed to BroadcastStreamJob #525

wants to merge 1 commit into from

Conversation

northeastprince
Copy link
Contributor

Fixes #522.

@northeastprince northeastprince mentioned this pull request Nov 27, 2023
Draft
@northeastprince northeastprince deleted the patch-1 branch November 30, 2023 14:46
@northeastprince northeastprince restored the patch-1 branch November 30, 2023 15:19
@seanpdoyle
Copy link
Contributor

I've shared my thoughts in #522 (comment), but to repeat them here:

I wonder if it'd be better to conditionally package an ActiveJob::Serializers::ObjectSerializer to special-case HTML safe strings.

@northeastprince northeastprince closed this by deleting the head repository Jan 8, 2024
@aprescott
Copy link

For anyone who might find this in future, this same change was later made in #683 (and included in v2.0.10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turbo::Streams::BroadcastStreamJob raising ActiveJob::SerializationError with ActiveSupport::SafeBuffer
3 participants
@northeastprince @seanpdoyle @aprescott