Support for multiple string arguments to frame helper #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
restore-dom
branch
2 times, most recently
from
f26b571
to
ffcbafc
Compare
jcoyne
added a commit
to sul-dlss/library_hours_rails
that referenced
this pull request
Oct 16, 2023
We can unpin when hotwired/turbo-rails#504 is merged and released
seanpdoyle
reviewed
Oct 16, 2023
| @@ -36,7 +36,7 @@ module Turbo::FramesHelper | |||
| # <%= turbo_frame_tag(Article.find(1), Comment.new) %> | |||
| # # => <turbo-frame id="article_1_new_comment"></turbo-frame> | |||
| def turbo_frame_tag(*ids, src: nil, target: nil, **attributes, &block) | |||
There was a problem hiding this comment.
Could you add an example to the documentation comment above like the one in https://github.com/hotwired/turbo-rails/pull/505/files#diff-7694cf5e712468388f0d32c6638e9d9508b612f0346ce4beb9093960a757fa59R26-R28?
There was a problem hiding this comment.
Yes, I've pulled your example in.
seanpdoyle
approved these changes
Oct 16, 2023
This fixes a regression in 1.5.0 Fixes hotwired#503
|
@seanpdoyle it looks like one of the tests is timing out and I don't have the permissions to restart it. |
|
I don't have permissions either. If you rebase the commit and force push, it'll run again |
|
@afcapel are you able to restart that one build? |
|
Thank you! Ran into this as well when upgrading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in 1.5.0
Fixes #503