Snapshot and deactivate Visitable during it's lifecycle feedback #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill appear to avoid double snapshots
pfeiffer
reviewed
Mar 4, 2024
Source/Session/Session.swift
Outdated
| @@ -35,6 +35,7 @@ public class Session: NSObject { | |||
|
|
|||
| private var currentVisit: Visit? | |||
| private var topmostVisit: Visit? | |||
| private var previosVisit: Visit? | |||
|
Looks good to me! Anything missing until we can get this merged? |
|
@joemasilotti & @jayohms - I think this is ready to merge! Would be great to avoid stale snapshot issues navigating between different sessions and while navigating between web and native screens. |
joemasilotti
added a commit
to hotwired/hotwire-native-ios
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some changes on top of #181.