Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch all exceptions when attempting to fetch the remote config and log errors #305

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Catch all exceptions when attempting to fetch the remote config and log errors #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion turbo/src/main/kotlin/dev/hotwire/turbo/config/TurboPathConfigurationRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.content.SharedPreferences
import androidx.core.content.edit
import dev.hotwire.turbo.http.TurboHttpClient
import dev.hotwire.turbo.util.dispatcherProvider
import dev.hotwire.turbo.util.logError
import dev.hotwire.turbo.util.toJson
import kotlinx.coroutines.withContext
import okhttp3.Request
Expand Down Expand Up @@ -43,10 +44,15 @@ internal class TurboPathConfigurationRepository {
if (response.isSuccessful) {
response.body?.string()
} else {
logError(
"remotePathConfigurationFailure",
Exception("location: ${request.url}, status code: ${response.code}")
)
null
}
}
} catch (e: IOException) {
} catch (e: Exception) {
logError("remotePathConfigurationException", e)
null
}
}
Expand Down
Loading