Anim replace root #304
Merged
Anim replace root #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Fix test Log whether a visit that has started is a page refresh Rename method for consistency with scrolling to anchor proposals Use nullable location reference Check for window.Turbo and add clarifying comment Fix the implementation so it properly works for Turbo 8 refreshes without any flickering. Use Turbo.navigator.location to determine the current location, so it works immediately cold boots and Turbo visits Bump minSdkVersion to 26 in the docs REPLACE_ROOT presentation - popUpTo to controller.graph.id (inclusive) Bump minSdkVersion to 26 Upgrade to SDK 34 and bump dependencies to latest versions Tweak the comment, since not all visit proposals will make it to the app After a form redirect to the same page location, don't replace the existing fragment with a new one for a visit Use the public strada dependency Add the overflow-menu component implementation Add the menu component implementation Configure the strada form path as a modal screen Add the form component implementation Intitial work to tie in Strada support with component examples Improve how debug logging is enabled and how exceptions are logged # Conflicts: # turbo/src/main/kotlin/dev/hotwire/turbo/nav/TurboNavRule.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up fixes to #286