-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - {FEEDBACK} 공용 ApiResponse, 피드백 컨트롤러 테스트 및 기능 구현 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakerdeft
added
🎯 Test
test 관련(storybook, jest...)
✨ Feature
기능 개발
⚙ Setting
개발 환경 세팅
labels
Sep 12, 2023
fakerdeft
changed the title
[FEATURE] - {FEEDBACK} 피드백 컨트롤러 테스트 및 기능 구현
[FEATURE] - {FEEDBACK} 공용 ApiResponse, 피드백 컨트롤러 테스트 및 기능 구현
Sep 12, 2023
Subak-Uncle
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한 사이클이 완성되었군요!! 👍🏻
...java/com/loveloveshot/feedback/command/application/controller/FeedbackCommandController.java
Outdated
Show resolved
Hide resolved
hodin030
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타 수정되면 바로 머지할게요~
네~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨(#이슈번호) 제목
✏️내용
공용 ApiResponse 세팅
피드백 컨트롤러 및 테스트 작성 완료
📸스크린샷
🎁참고사항