Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from lit-html to vue #304

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

The-x-35
Copy link

@The-x-35 The-x-35 commented Jul 27, 2024

Closes #300

I replaced the code popup-script.ts to call an App.vue file with the vue code and reimplemented all the functionalities and designs exactly in App.vue. I have tested it and it works same as before.

@amk-dev amk-dev self-requested a review August 22, 2024 15:20
Copy link
Collaborator

@amk-dev amk-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look into the comments

package.json Outdated Show resolved Hide resolved
"lit-html": "^3.0.0",
"vue": "^3.4.33"
},
"packageManager": "pnpm@9.5.0+sha256.dbdf5961c32909fb030595a9daa1dae720162e658609a8f92f2fa99835510ca5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are discussions happening on the node level to remove some ambiguity with defining package managers like this.

we can revisit this once we've more clarity on the matter on industry level. for now we can remove it.

Copy link
Author

@The-x-35 The-x-35 Aug 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir I have not added this line, it was added implicitly by the corepack and when I try to remove it and try to build the project again, it gets added back automatically by the corepack. You can see in the below screenshot

image

I checked the docs and could not find a way to remove it, so keeping this in the next commit in this PR.

src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
@amk-dev amk-dev changed the title Solving issue #300 migrate from lit-html to vue components chore: migrate from lit-html to vue Aug 22, 2024
@The-x-35 The-x-35 requested a review from amk-dev August 25, 2024 13:06
@The-x-35
Copy link
Author

The-x-35 commented Aug 25, 2024

Sir, I have raised the commit doing all the changes requested.
Just the package manager issue, I am unable to solve, please check the comments on that when to see the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate from lit-html to vue components
2 participants