-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate from lit-html to vue #304
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look into the comments
"lit-html": "^3.0.0", | ||
"vue": "^3.4.33" | ||
}, | ||
"packageManager": "pnpm@9.5.0+sha256.dbdf5961c32909fb030595a9daa1dae720162e658609a8f92f2fa99835510ca5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are discussions happening on the node level to remove some ambiguity with defining package managers like this.
we can revisit this once we've more clarity on the matter on industry level. for now we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir I have not added this line, it was added implicitly by the corepack and when I try to remove it and try to build the project again, it gets added back automatically by the corepack. You can see in the below screenshot
I checked the docs and could not find a way to remove it, so keeping this in the next commit in this PR.
Sir, I have raised the commit doing all the changes requested. |
Closes #300
I replaced the code popup-script.ts to call an App.vue file with the vue code and reimplemented all the functionalities and designs exactly in App.vue. I have tested it and it works same as before.