Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile for env, dev, and django example #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dotysan
Copy link
Contributor

@dotysan dotysan commented Jun 2, 2023

  • migrate setup.py develop to pip install
  • also ignore other env and working files

 - migrate setup.py develop to pip install
 - also ignore other env and working files
@subzero10
Copy link
Member

Hey @dotysan, thanks for submitting this PR!

There's already an issue #127 to use a dependency manager, what is your opinion on using Make + pip vs the other options listed in the issue?

@dotysan
Copy link
Contributor Author

dotysan commented Jun 3, 2023

Well...a small/simple Makefile with venv is just my personal crutch. It's mostly out of habit. And just because I can easily read/edit/execute it.

I really don't have much experience with Pipenv, Poetry, PDM.

I did, however, bootstrap a pip module with Flit last month and it worked swimmingly! I also enjoyed tinkering with Hatch, but in the end Flit met my simple needs.

In a different branch, I'm in the process of moving tests to tox and requirements out of setup.py into pip --require files for both dev and test. Maybe after that, this will all be moot...

@subzero10
Copy link
Member

Well...a small/simple Makefile with venv is just my personal crutch. It's mostly out of habit. And just because I can easily . > read/edit/execute it.

I really don't have much experience with Pipenv, Poetry, PDM.

I see your point, though it means the Makefile needs to be maintained as the package evolves. I would like to explore at least one of these dependency management tools first.

I did, however, bootstrap a pip module with Flit last month and it worked swimmingly! I also enjoyed tinkering with Hatch, but in the end Flit met my simple needs.

I didn't know about Flit, we use Twine to deploy this package :).

In a different branch, I'm in the process of moving tests to tox and requirements out of setup.py into pip --require files for both dev and test. Maybe after that, this will all be moot...

I guess we should wait for that branch then, right?

@dotysan
Copy link
Contributor Author

dotysan commented Jun 8, 2023

I've moved all the heavy lifting into tox here. #153

And I still use the lightweight Makefile for only constructing my local dev/venv, dependencies, and repetitive tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants