Merge pull request #196 from zickgraf/master

Do not fall back to create_func_morphism for "morphism_or_fail"
homalg-project · May 1, 2023 · 1aacab2 · 1aacab2
2 parents 1d5e0fb + e2e1b33
commit 1aacab2
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 12 deletions.
diff --git a/CategoryConstructor/PackageInfo.g b/CategoryConstructor/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "CategoryConstructor",
 Subtitle := "Construct categories out of given ones",
-Version := "2023.04-02",
+Version := "2023.05-01",
 
 Date := ~.Version{[ 1 .. 10 ]},
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),

diff --git a/CategoryConstructor/gap/CategoryConstructor.gi b/CategoryConstructor/gap/CategoryConstructor.gi
@@ -161,7 +161,7 @@ InstallMethod( CategoryConstructor,
     ## e.g., IdentityMorphism, PreCompose
     create_func_morphism := CAP_INTERNAL_RETURN_OPTION_OR_DEFAULT( "create_func_morphism", fail );
 
-    ## e.g., Lift
+    ## e.g., LiftOrFail
     create_func_morphism_or_fail := CAP_INTERNAL_RETURN_OPTION_OR_DEFAULT( "create_func_morphism_or_fail", fail );
 
     ## e.g., CokernelColiftWithGivenCokernelObject
@@ -201,12 +201,6 @@ InstallMethod( CategoryConstructor,
     fi;
 
     # set default values
-    if create_func_morphism_or_fail = fail then
-
-        create_func_morphism_or_fail := create_func_morphism;
-
-    fi;
-
     if create_func_universal_morphism = fail then
 
         create_func_universal_morphism := create_func_morphism;

diff --git a/IntrinsicGradedModules/PackageInfo.g b/IntrinsicGradedModules/PackageInfo.g
@@ -11,7 +11,7 @@ SetPackageInfo( rec(
 PackageName := "IntrinsicGradedModules",
 Subtitle := "Finitely presented graded modules over computable graded rings allowing multiple presentations and the notion of elements",
 
-Version := "2023.02-05",
+Version := "2023.05-01",
 Date := ~.Version{[ 1 .. 10 ]},
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",

diff --git a/IntrinsicGradedModules/examples/PresentationWithDegrees.g b/IntrinsicGradedModules/examples/PresentationWithDegrees.g
@@ -17,7 +17,7 @@ Display( A );
 #! IntrinsicCategory( CategoryWithAmbientObjects(
 #! Freyd( GradedRows( Q[x,y,z] (with weights [ 1, 1, 1 ]) ) ) ) ):
 #! 
-#! 121 primitive operations were used to derive 312 operations for this category
+#! 119 primitive operations were used to derive 310 operations for this category
 #! which algorithmically
 #! * IsEquippedWithHomomorphismStructure
 #! * IsAbelianCategoryWithEnoughProjectives

diff --git a/IntrinsicGradedModules/gap/FpGradedModulesByFreyd.autogen.gd b/IntrinsicGradedModules/gap/FpGradedModulesByFreyd.autogen.gd
@@ -47,7 +47,6 @@
 #! * <Ref BookName="CAP" Func="CokernelProjectionWithGivenCokernelObject" Label="for Is" />
 #! * <Ref BookName="CAP" Func="Colift" Label="for Is" />
 #! * <Ref BookName="CAP" Func="ColiftAlongEpimorphism" Label="for Is" />
-#! * <Ref BookName="CAP" Func="ColiftOrFail" Label="for Is" />
 #! * <Ref BookName="CategoryConstructor" Func="Colimit" Label="for Is" />
 #! * <Ref BookName="CAP" Func="ComponentOfMorphismFromCoproduct" Label="for Is" />
 #! * <Ref BookName="CAP" Func="ComponentOfMorphismFromDirectSum" Label="for Is" />
@@ -189,7 +188,6 @@
 #! * <Ref BookName="MonoidalCategories" Func="LeftUnitorWithGivenTensorProduct" Label="for Is" />
 #! * <Ref BookName="CAP" Func="Lift" Label="for Is" />
 #! * <Ref BookName="CAP" Func="LiftAlongMonomorphism" Label="for Is" />
-#! * <Ref BookName="CAP" Func="LiftOrFail" Label="for Is" />
 #! * <Ref BookName="CategoryConstructor" Func="Limit" Label="for Is" />
 #! * <Ref BookName="CategoryConstructor" Func="MereExistenceOfUniqueSolutionOfHomogeneousLinearSystemInAbCategory" Label="for Is" />
 #! * <Ref BookName="MonoidalCategories" Func="MonoidalPostComposeMorphism" Label="for Is" />