Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #251 and other minor adjustments:
config.php.example
)I believe that the automatic redirection should be completely opt-in by users of an instance, since redirecting to another, potentially unknown, site can be a major security and privacy concern. Imagine if one instance went rouge and was still listed in
instances.json
, users of a completely unrelated instance may be redirected to this instance unwillingly and this may lead to this user's search results getting compromised, among other things. That's why I have set the defaults as above, allowing the user the choice to redirect to other instances if they want, while also allowing instance maintainers themselves to disable the feature entirely.As far as "trusted instances" go, I urge any instance maintainers that do wish to keep redirection on to maintain
instances.json
as they see fit, though unfortunately this is not configurable by the user themselves.Please test out this PR and let me know if there is anything broken / missing, especially since I am not all that confident in php myself. Thank you