Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic redirection #251

Open
Ahwxorg opened this issue Jun 24, 2023 · 8 comments
Open

Automatic redirection #251

Ahwxorg opened this issue Jun 24, 2023 · 8 comments

Comments

@Ahwxorg
Copy link
Contributor

Ahwxorg commented Jun 24, 2023

What?
This issue is about automatic redirection, which was added in commit 7559bc8101fd09a6d946c5b87f0be5ebaccf4031, and edited in commit e03b930386caff3b8cc0de4c059a8666a15a2741.

The issue
The issue is that (I am assuming most people) people (like me) do not want to automatically redirect their queries to another instance for whatever reasons.

Possible solution
A few solutions would be:

  • You could make it opt-in in the settings, which seem to be based on cookies.
  • You could also make a clickable "This instance seems to not give results on your query. Do you want to try on another instance?".
  • You could also make a different URL path for automatic redirection, and disable it on the default search.php?q=%s.
  • You could also make a parameter such as search.php?q=%s&ar=true where ar is set to true/false based on the settings, with a default of false.

I also think it's also very important to make a list of "trusted instances", which the users are able to set by themselves, so that LibreX only redirects to those instances.

Extra idea

I personally think it should also be a setting you can change in the config.php since I like to clear cookies, but I don't think most people would agree. You could also make a default in the config.php which users can toggle in the settings with a default of enabled=false.

Let me know if any of these ideas are a good idea, and I would be willing to try to implement them.

@gospodin55
Copy link

gospodin55 commented Jun 27, 2023

I made this and was extremely surprised when it was just merged. I expected to receive suggestions by hnhx about how it should be implemented differently.
I think it should be a clickable text suggesting to redirect to other instance, maybe not random but from config.php or cookies. Maybe it should be integrated with something like libredirect

@Ahwxorg
Copy link
Contributor Author

Ahwxorg commented Jun 28, 2023

Yeah, that's what I said. @hnhx could this be implemented the correct way?

@Ahwxorg
Copy link
Contributor Author

Ahwxorg commented Jun 28, 2023

I'm not updating my instance untill its patched correctly, as this is a huge privacy concern for me.

@torunar
Copy link

torunar commented Aug 1, 2023

It also breaks API: when search results are queried through API and Google starts rate limiting, user is redirected to search on the other instance instead of API.

@Ahwxorg
Copy link
Contributor Author

Ahwxorg commented Aug 1, 2023

@hnhx bumping this again

@gospodin55
Copy link

Maybe someone should fork librex, waiting for hnhx is too long

@Ahwxorg
Copy link
Contributor Author

Ahwxorg commented Aug 1, 2023

I will.

@codedipper
Copy link
Contributor

https://github.com/Ahwxorg/LibreY <3

This was referenced Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants