-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic redirection #251
Comments
I made this and was extremely surprised when it was just merged. I expected to receive suggestions by hnhx about how it should be implemented differently. |
Yeah, that's what I said. @hnhx could this be implemented the correct way? |
I'm not updating my instance untill its patched correctly, as this is a huge privacy concern for me. |
It also breaks API: when search results are queried through API and Google starts rate limiting, user is redirected to search on the other instance instead of API. |
@hnhx bumping this again |
Maybe someone should fork librex, waiting for hnhx is too long |
I will. |
What?
This issue is about automatic redirection, which was added in commit 7559bc8101fd09a6d946c5b87f0be5ebaccf4031, and edited in commit e03b930386caff3b8cc0de4c059a8666a15a2741.
The issue
The issue is that (I am assuming most people) people (like me) do not want to automatically redirect their queries to another instance for whatever reasons.
Possible solution
A few solutions would be:
"This instance seems to not give results on your query. Do you want to try on another instance?"
.search.php?q=%s
.search.php?q=%s&ar=true
wherear
is set to true/false based on the settings, with a default of false.I also think it's also very important to make a list of "trusted instances", which the users are able to set by themselves, so that LibreX only redirects to those instances.
Extra idea
Let me know if any of these ideas are a good idea, and I would be willing to try to implement them.
The text was updated successfully, but these errors were encountered: