Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising http4s clients through middlewares #192

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

ybasket
Copy link
Contributor

@ybasket ybasket commented Aug 16, 2023

By having an optional middleware that is applied to the underlying http4s client, users can customise the client's behaviour, for example to log requests or trace them. The apply methods are overloaded (instead of using defaults) for better bincompat.

First discussed in #188.

By having an optional middleware that is applied to the underlying http4s client, users can customise the client's behaviour, for example to log requests or trace them. The apply methods are overloaded (instead of using defaults) for better bincompat.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and welcome!
We are glad that you are here and we appreciate your contributions.

Copy link
Owner

@hnaderi hnaderi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thank you!

@hnaderi hnaderi merged commit 0f8d4e3 into hnaderi:main Aug 17, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants