Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update fetch input types to account for Request object as first … #1766

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Nov 18, 2024

This PR was published to npm with the version 7.0.3-pr.4+64a49b58
e.g. npm install @stacks/common@7.0.3-pr.4+64a49b58 --save-exact

  • I think we need this for better compat with the createClient approach. Mainly for types, but also a fetch param could look different from the only string format supported currently (even though maybe this mainly already works... probably)
  • Added a url: fetchParams.input so this won't impact current code (just show deprecation notice)

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 0:21am

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/common/src/fetch.ts 85.71% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

1 participant