Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Minor refactoring to match common theme #1749

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 22, 2024

This PR was published to npm with the version 6.14.1-pr.81+e6f2832a
e.g. npm install @stacks/common@6.14.1-pr.81+e6f2832a --save-exact

  • refactor some uint8array methods to match the general theme
  • remove unneeded overloads
  • add @ignore and deprecation comments

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:06pm

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement suggestion

packages/stacking/src/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@janniks janniks force-pushed the 10-21-fix_switch_to_a_network_and_client_param_solution branch from 8cf2e30 to d753ab2 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-22-refactor_minor_refactoring_to_match_common_theme branch from e6f2832 to 0676a06 Compare October 25, 2024 18:55
Base automatically changed from 10-21-fix_switch_to_a_network_and_client_param_solution to next October 25, 2024 18:55
@janniks janniks force-pushed the 10-22-refactor_minor_refactoring_to_match_common_theme branch from 0676a06 to fa9be48 Compare October 25, 2024 18:55
@janniks janniks merged commit 89dad33 into next Oct 25, 2024
3 of 5 checks passed
@janniks janniks deleted the 10-22-refactor_minor_refactoring_to_match_common_theme branch October 25, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants