-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
null safety added to the project #77
base: master
Are you sure you want to change the base?
Conversation
@VaishnaviSood Was there a requirement to update the environment SDK? And can you attach a gif of the checkout window on the cart screen, so that I can verify that Razorpay is still working along with the Adobe XD. |
@VaishnaviSood do response whenever you can because I would like to merge this PR as soon as possible. |
Firstly sorry for the late reply... and yes it was a requirement to update the SDK as the latest version of Dart supports null safety. WhatsApp.Video.2021-03-09.at.11.44.38.PM.mp4 |
Okay @VaishnaviSood thanks for the update, let the PR exists until we somewhat finalise this app. You can create the null safety issue in these plugins as I told you earlier. And you can proceed with other issues. I'll let you know when to update this PR. |
@VaishnaviSood I am converting this PR to draft. I'll try to release the null safety version of Razorpay as soon as possible to make the project sound null safe. |
ohkay!...That's good...but the adobe_xd package also did not have a null safe version. If you could do something about that. And do inform me when its all done..I'll make the required changes |
I think we can remove the adobe_xd, I'll check it and update you soon. |
db75c40
to
be53d29
Compare
Migrated the dependencies to null-safety (adobe_xd and razorpay_flutter are not compatible with null safety which caused problems). So now the project is not sound null safe. It is a type of mixed version. I thoroughly checked the code for non-nullable and nullable types and edited the code accordingly. If there is any issue regarding it, please inform..
Closes #64