Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for v.1.8.2 #182

Merged
merged 6 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@

Release 1.8.2
=========================================

* **BUGFIX:** Added missing support for ``'areaMarker'`` legend symbol.
* **DOCS:** Fixed some typos (courtesy of @JulienBacquart).

----

Release 1.8.1
=========================================

Expand Down
1 change: 1 addition & 0 deletions docs/_contributors.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
* Byron Cook (`@ByronCook <https://github.com/ByronCook>`__)
* karlacio (`@karlacio <https://github.com/karlacio>`__)
* Max Dugan Knight (`@maxduganknight <https://github.com/maxduganknight>`__)
* Julien Bacquart (`@JulienBacquart <https://github.com/JulienBacquart>`__)
4 changes: 2 additions & 2 deletions docs/tutorials/data.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
########################################################
Using Highcharts Core for Python with Pandas
Working with Data in Highcharts for Python
########################################################

.. contents::
Expand All @@ -8,7 +8,7 @@ Using Highcharts Core for Python with Pandas

-------------------

The **Highcharts for Python Toolkit** is a data *visualizaiton* library.
The **Highcharts for Python Toolkit** is a data *visualization* library.
That means that it is designed to let you visualize the data that you
or your users are analyzing, rather than to do the analysis itself. But
while there are better tools to actually crunch the numbers,
Expand Down
2 changes: 1 addition & 1 deletion highcharts_core/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '1.8.1'
__version__ = '1.8.2'
9 changes: 6 additions & 3 deletions highcharts_core/options/plot_options/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ def label(self, value):
@property
def legend_symbol(self) -> Optional[str]:
"""The type of legend symbol to render for the series. Accepts either
``'lineMarker'`` or ``'rectangle'``. Defaults to ``'rectangle'``.
``'lineMarker'``, ``'areaMarker'``, or ``'rectangle'``. Defaults to
``'rectangle'``.

:rtype: :class:`str <python:str>`
"""
Expand All @@ -510,9 +511,11 @@ def legend_symbol(self, value):
value = value.lower()
if value == 'linemarker':
value = 'lineMarker'
if value not in ['lineMarker', 'rectangle']:
if value == 'areamarker':
value = 'areaMarker'
if value not in ['lineMarker', 'areaMarker', 'rectangle']:
raise errors.HighchartsValueError(f'legend_symbol expects either '
f'"lineMarker" or "rectangle". '
f'"lineMarker", "areaMarker", or "rectangle". '
f'Received: "{value}".')
self._legend_symbol = value

Expand Down
Loading