Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Bash to Shell everywhere #223

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

hansfn
Copy link
Contributor

@hansfn hansfn commented Aug 9, 2024

Updates function names to match the earlier change from "bash" to "sh".
Removes last instance of "bash" execution.

Resolves #215

Updates function names to match the earlier change from "bash" to "sh".
Removes last instance of "bash" execution.

Resolves hendrikmuhs#215
Trying to fix test / build failure. EOL inserted by editor (vim) automatically.
@hansfn
Copy link
Contributor Author

hansfn commented Aug 9, 2024

Do you normally update the dist folder just before a release or do you want the commit / PR to update both the source and dist files (like I did here). If I hadn't touch the dist files, I would have avoided the EOL file issue. Another way to avoid the EOL problem would have been to compile the source of course. I just edited the dist files by hand. My bad.

@hansfn
Copy link
Contributor Author

hansfn commented Aug 11, 2024

Another observation: The ccache stats are displayed without using the shell wrapper - any reason for this? It seems inconsistent.

@hendrikmuhs
Copy link
Owner

Sorry for the slow response. I am currently on vacation.

I don't remember a reason for ccache stats not using a shell wrapper. If I remember correctly the shell wrapper was added later only for some functions.

Another way to avoid the EOL problem would have been to compile the source of course.

I agree, this would be better. I simply do not find the time to do such improvements.

@hendrikmuhs hendrikmuhs merged commit eecbcad into hendrikmuhs:main Sep 5, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to store cache on alpine linux due to missing bash
2 participants