Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Filter by mode for command_pallete (Spc-?) #12115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darshanCommits
Copy link

Now you can filter by mode while searching for correct keybind.

image

First time contribution, and not a very experienced dev (more so in rust)
Review outside of core maintainers appreciated.

@david-crespo
Copy link
Contributor

david-crespo commented Nov 23, 2024

Does that mean there is now an entry in the list for all three modes for every command? It will feel weird if you search by command name and get three rows every time.

One way to avoid that would be to a bindings column for each mode. That way the three modes are all in one row. But that could get weird in other ways, and would take up more horizontal space.

@darshanCommits
Copy link
Author

Good catch.
How should this be handled?

How about, unless %m provided, only result in the current mode?

@the-mikedavis the-mikedavis added the A-command Area: Commands label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants