Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remap "add cursor above" to D instead of Alt-C #12072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NikitaRevenco
Copy link

@NikitaRevenco NikitaRevenco commented Nov 15, 2024

There have been several discussions that people would prefer if the editor did not make any default Alt-* keymappings:

So this PR is going to help a little bit with that.

I remapped Alt-C (copy_selection_on_prev_line) to D because it adds a cursor above, and D is above the C key.

Alt-C requires 3 keystrokes (alt, shift, C) and is uncomfortable to type

To me, it makes sense that D and C will be together. The C which adds a cursor below, is lower. And D which adds a cursor above, is above C. I think there is logic to that.

D is also not mapped to anything at the moment.

This is just my opinion and if you have a better place to put this keymap then please let me know! I feel like the alt-* keymappings should be gradually removed

@kirawi
Copy link
Member

kirawi commented Nov 15, 2024

Thanks for the PR.

To me, it makes sense that D and C will be together. The C which adds a cursor below, is lower. And D which adds a cursor above, is above C. I think there is logic to that.

This is only on QWERTY. We generally don't choose keybindings based on positions, and instead try to make them easy to remember. We are also fairly conservative about changing keymaps since this would be a huge breaking change for a lot of people's muscle memory. Actually, I think right now the maintainers don't have much interest in changing the keymaps in general since they can be rebound in people's configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants