Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search_assets): Issue with field deserialization #90

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

fix(search_assets): Issue with field deserialization #90

wants to merge 7 commits into from

Conversation

power-law
Copy link

Within the Asset type, there was an incorrect #[serde(rename = "tokenSupply")] for the token_info field. As is, it always returns None because there is no tokenSupply field in the response body.

@power-law
Copy link
Author

I recognize this could just be due to an incoming change on the server-side, so please close if so.

0xIchigo
0xIchigo requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I'd love to try it out. However, it looks like the build is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xIchigo 0xIchigo 0xIchigo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@power-law @0xIchigo