-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round Flag Icons + Helper Utils #10
Open
xsorifc28
wants to merge
52
commits into
heetch:master
Choose a base branch
from
xsorifc28:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added round icons - Method to get round mipmaps
# Conflicts: # build.gradle # gradle/wrapper/gradle-wrapper.properties # src/main/java/com/heetch/countrypicker/CountryPickerDialog.java
Conflicts: build.gradle
Conflicts: .gitignore build.gradle
…WITH PREVIOUS RELEASES!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I had PR'ed a version with round flags, but these were resource files which made the library size bigger.
This PR removes those files and adds a programmatic way to generate round icons (via bitmap or resource id).
Also added are some methods to get the country code via name and vice versa.
I found these helpful. If you have any questions, or there are any incompatibilities, I'm happy to resolve.
Let me know your thoughts.