Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 Support and Add 3.13 Support #1209

Merged
merged 43 commits into from
Nov 15, 2024
Merged

Remove Python 3.8 Support and Add 3.13 Support #1209

merged 43 commits into from
Nov 15, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Nov 14, 2024

Motivation

Remove Python 3.8 Support
Fix #1207

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (c71537a) to head (5233c9c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1209      +/-   ##
==========================================
+ Coverage   90.92%   90.94%   +0.01%     
==========================================
  Files          43       43              
  Lines        9525     9522       -3     
  Branches     2722     2722              
==========================================
- Hits         8661     8660       -1     
+ Misses        571      569       -2     
  Partials      293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review November 14, 2024 19:44
requirements-min.txt Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@rly
Copy link
Contributor

rly commented Nov 14, 2024

Can you also add python 3.13 to the tests?

@mavaylon1 mavaylon1 requested a review from rly November 14, 2024 23:38
@rly rly changed the title Remove Python 3.8 Support Remove Python 3.8 Support and Add 3.13 Support Nov 15, 2024
@mavaylon1 mavaylon1 merged commit 26d584c into dev Nov 15, 2024
28 of 29 checks passed
@mavaylon1 mavaylon1 deleted the py38 branch November 15, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Python 3.8
2 participants