-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route array representation for HTML #1206
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1206 +/- ##
==========================================
- Coverage 90.95% 90.82% -0.13%
==========================================
Files 43 43
Lines 9506 9524 +18
Branches 2719 2723 +4
==========================================
+ Hits 8646 8650 +4
- Misses 568 580 +12
- Partials 292 294 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a minor enhancement to avoid repeat calls to get_read_io
. Otherwise this looks good to me 👍
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
Thakns @oruebel . I submited the suggestions |
Improved version of #1201