Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route array representation for HTML #1206

Merged
merged 16 commits into from
Nov 23, 2024
Merged

Conversation

h-mayorquin
Copy link
Contributor

Improved version of #1201

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (4fb554a) to head (273055d).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf/container.py 50.00% 5 Missing and 2 partials ⚠️
src/hdmf/utils.py 40.00% 5 Missing and 1 partial ⚠️
src/hdmf/backends/hdf5/h5tools.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1206      +/-   ##
==========================================
- Coverage   90.95%   90.82%   -0.13%     
==========================================
  Files          43       43              
  Lines        9506     9524      +18     
  Branches     2719     2723       +4     
==========================================
+ Hits         8646     8650       +4     
- Misses        568      580      +12     
- Partials      292      294       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/hdmf/container.py Outdated Show resolved Hide resolved
src/hdmf/container.py Outdated Show resolved Hide resolved
@h-mayorquin h-mayorquin marked this pull request as ready for review November 12, 2024 05:04
@rly rly requested a review from oruebel November 18, 2024 07:33
src/hdmf/container.py Outdated Show resolved Hide resolved
src/hdmf/container.py Outdated Show resolved Hide resolved
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a minor enhancement to avoid repeat calls to get_read_io. Otherwise this looks good to me 👍

h-mayorquin and others added 2 commits November 22, 2024 21:09
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
@h-mayorquin
Copy link
Contributor Author

Thakns @oruebel . I submited the suggestions

@oruebel oruebel merged commit 1d3421e into hdmf-dev:dev Nov 23, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants