Use setup-ocaml github action #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7h3kk1d
force-pushed
the
setup-ocaml-action
branch
from
63bc82c
to
4fe8109
Compare
7h3kk1d
commented
Jul 30, 2024
cyrus-
requested changes
Aug 8, 2024
This was referenced Aug 9, 2024
7h3kk1d
commented
Aug 10, 2024
7h3kk1d
commented
Aug 16, 2024
7h3kk1d
force-pushed
the
setup-ocaml-action
branch
from
78bcb2d
to
691a89d
Compare
cyrus-
approved these changes
Aug 17, 2024
|
Merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to https://github.com/ocaml/setup-ocaml for the ocaml installation step. Adds a
hazel.opam.lockedfile to keep track of exact dependency versions that we depend on. Also adds adune-projectfile to manage project dependencies and it generates thehazel.opamfile ondune build. So we can keep track of intentional vs unintentional dependency locking which should be useful for upgrading. Also intentionally caching the opam switch separately from the ocaml compiler itself which seems more deterministic as far as caches go.The last cached build took about 3m https://github.com/hazelgrove/hazel/actions/runs/10115441982/job/27976209701