Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for sha256 image tags in operand reference #97

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Adds support for sha256 image tags in operand reference #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c13bb
fix: Adds support for sha256 tag checksums #96
phantomjinx Dec 12, 2023
2b22a00
fix: Corrects docker build command
phantomjinx Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ image:
docker build -t $(IMAGE):$(VERSION) \
--build-arg HAWTIO_ONLINE_IMAGE_NAME=$(HAWTIO_ONLINE_IMAGE_NAME) \
--build-arg HAWTIO_ONLINE_VERSION=$(HAWTIO_ONLINE_VERSION) \
.

#---
#
Expand Down
6 changes: 6 additions & 0 deletions pkg/resources/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package resources

import (
"os"
"strings"

corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -62,5 +63,10 @@ func getImageFor(tag string, imageRepository string) string {
}
}

if strings.HasPrefix(tag, "sha256:") {
// tag is a sha checksum tag
return repository + "@" + tag
}

return repository + ":" + tag
}
Loading