Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAWNG-646: Default connection modal to https scheme #930

Merged
merged 1 commit into from
May 13, 2024

Conversation

phantomjinx
Copy link
Member

  • Makes the switch on the ConnectionModal default to https

@phantomjinx phantomjinx added this to the 2024Q2 milestone May 8, 2024
@phantomjinx phantomjinx self-assigned this May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Test Results

  8 files  ±0    8 suites  ±0   49m 51s ⏱️ + 1m 57s
 65 tests  - 1   63 ✅  - 1   2 💤 ±0  0 ❌ ±0 
528 runs   - 8  500 ✅  - 8  28 💤 ±0  0 ❌ ±0 

Results for commit 5830f31. ± Comparison against base commit 95be600.

This pull request removes 1 test.
Checking the functionality of Help page. ‑ Check that the tabs contain data - Standard Help page tabs - Example #1.5

♻️ This comment has been updated with latest results.

@phantomjinx
Copy link
Member Author

https selected by default:

Screenshot_20240508_133246

@hawtio-ci
Copy link

hawtio-ci bot commented May 8, 2024

Test results

Run attempt: 1688
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 66 63 3 0 0 371.385
results-quarkus-node(18)-java(21)-firefox 66 63 3 0 0 372.314
results-quarkus-node(20)-java(17)-firefox 66 63 3 0 0 371.629
results-quarkus-node(20)-java(21)-firefox 66 63 3 0 0 373.652
results-springboot-node(18)-java(17)-firefox 66 62 4 0 0 372.089
results-springboot-node(18)-java(21)-firefox 66 62 4 0 0 376.583
results-springboot-node(20)-java(17)-firefox 66 62 4 0 0 381.663
results-springboot-node(20)-java(21)-firefox 66 62 4 0 0 372.403

@phantomjinx
Copy link
Member Author

@jsolovjo
Looks like this broke the e2e tests?

@jsolovjo
Copy link

jsolovjo commented May 8, 2024

@jsolovjo Looks like this broke the e2e tests?

seems yes
as the tests use simple http connection
I can fix it

* Makes the switch on the ConnectionModal default to https
@phantomjinx phantomjinx merged commit 00f24ed into hawtio:main May 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants