Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect): HAWNG-487 apply authentication throttling to connect login #894

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

tadayosi
Copy link
Member

@tadayosi
Copy link
Member Author

@kariuwu @grgrzybek Can you please review this?

@tadayosi tadayosi force-pushed the HAWNG-487-connect-login-throttle branch from bb67c2e to 57a035d Compare April 23, 2024 06:34
@hawtio-ci
Copy link

hawtio-ci bot commented Apr 23, 2024

Test results

Run attempt: 1532
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 377.527
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 373.859
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 373.743
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 371.238
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 375.999
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 368.986
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 374.079
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 379.359

@grgrzybek
Copy link
Contributor

Looks good - there are no changes required at hawtio/hawtio side, right?

Copy link

Test Results

  8 files  ±0    8 suites  ±0   49m 54s ⏱️ +3s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 57a035d. ± Comparison against base commit 131a2c8.

@tadayosi
Copy link
Member Author

@grgrzybek Thanks.

Looks good - there are no changes required at hawtio/hawtio side, right?

No, no changes required. It's based on the existing capability in hawtio/hawtio.

However, just FYI, if we would look into HAWNG-487 more seriously, ideally there can be a few more enhancements from hawtio/hawtio and jolokia sides, including:

Anyway, we should work on them after product GA if we do.

@tadayosi tadayosi merged commit 4203663 into hawtio:main Apr 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants