Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Routes): Add the state label to the routes list #881

Merged
merged 2 commits into from
Apr 18, 2024
Merged

chore(Routes): Add the state label to the routes list #881

merged 2 commits into from
Apr 18, 2024

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Apr 16, 2024

Screenshot 2024-04-16 at 16 22 44

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Test Results

  8 files  ±0    8 suites  ±0   50m 1s ⏱️ -23s
 66 tests ±0   64 ✅ +2   2 💤 ±0  0 ❌  - 2 
536 runs  ±0  508 ✅ +2  28 💤 ±0  0 ❌  - 2 

Results for commit 26a6b3d. ± Comparison against base commit 314b9c8.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Apr 16, 2024 •
edited
Loading

Test results

Run attempt: 1500
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 371.436
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 371.056
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 376.401
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 376.291
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 375.836
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 374.519
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 378.444
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 377.216

tadayosi
tadayosi approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, but one comment.

packages/hawtio/src/plugins/camel/routes/CamelRoutes.tsx Outdated Show resolved Hide resolved
@mmelko
Copy link
Collaborator Author

mmelko commented Apr 17, 2024

I also refactored the test in the BlockedExchanges. Looks like there were a change of the behaviour after the upgrade of the react/testing-library in findBy...

@tadayosi tadayosi merged commit 4c1e92c into hawtio:main Apr 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmelko @tadayosi