Changes to <HawtioLogin> to allow for plugin to provide customisations #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantomjinx
changed the title
|
Is a dependency of hawtio/hawtio-online#155 |
Test Results 8 files ±0 8 suites ±0 1h 0m 26s ⏱️ + 2m 3s For more details on these failures, see this check. Results for commit 9abd083. ± Comparison against base commit 6bcaec8. ♻️ This comment has been updated with latest results. |
Test resultsRun attempt: 609
|
tadayosi
approved these changes
Oct 13, 2023
|
Please fix lint error too. |
* HawtioLogin.tsx * Looks at HawtConfig for title * Checks if there is an active login plugin available and substitutes its component for the login form * Should no plugin be available then the default HawtioLoginForm is loaded * Awaits on all plugins being loaded since otherwise the plugins array from usePlugins() will be empty * HawtioLoginForm.tsx * Default delegate form that a user populate with user/password * core.ts * Adds isLogin property to the Plugin interface to flag the plugin as a login plugin * HawtioPage.tsx * Ensures that the login plugins are filtered out of the page plugins
* During jmx plugin resolution, its isActive() function tries to load the tree but listing nodes from the jolokiaService. Seems that even though it waits on the userService.isLogin(), it then gets stuck after if not logged-in. This now results in the plugin never reporting itself as loaded and 'plugins' in usePlugins() hook remains empty. * By not just awaiting but observing the isLogin() return value, this can be avoided by returning a null url and so causing the jolokiaService to create a DummyJolokia tree instead. This makes sense since no list of nodes can possibly be made if not logged-in.
* [rbac|jolokia]-service / workspace * Services constructed on load cannot have jolokia-related functions executed in their constructors. Doing so prior to userService.fetchUser() being called will now result in an error being thrown that the user is not logged in. * Each public function from the services is therefore provided with an init() function which does the job of the constructor, ensuring the jolokia-related members are initialised correctly, once it has been established that the user is logged-in. * core.ts * Plugins should only be activated if the user has been logged-in with the exception of those plugins, specifically advertising themselves as 'isLogin' type plugins, ie. plugins providing a custom login form. * Only if the user is logged-in will other plugins determine if they can be activated by calling their isActive() functions.
* Locally, executing the unit tests causes numerous errors with auth/globals.ts/Logger being 'undefined'. * Due to inclusion of userService in core.ts the auth and core packages are circular associated via the userService and Logger
…wtio#594 * Since tests make use of services, such as workspace, it is now essential that the userService is initialised by them to ensure the environment is correctly setup for the test to execute.
phantomjinx
force-pushed
the
auth-form
branch
from
5ba4cb8
to
9abd083
Compare
|
There are a few issues that need to be addressed in the latest fix. But instead of running another cycle of commit & review, I can take care of them after merging it. Feel free to turn it to "ready for merge" and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most changes concern updating the UI of the
<HawtioLogin/>to support a customised child login form, a necessary change is also included for theJolokiaService. Specifically, the use-case concerns what happens when logging-out occurs.When the logging-out button is clicked, the app routes back to
/loginbut was stuck on displaying the waiting symbol.Analysis showed that because
<HawtioLogin>is now using theusePluginshook, the component waits on thepluginsLoadedflag. This was never returningtrueindicating that the plugins were never completing resolution. Digging in further indicated that despite not being logged-in theJMXplugin was, as a result of itsisActive()plugin function, still trying to list nodes from thejolokiaServiceyet this process was hanging.This has been resolved by, since the service was already waiting for the
userService.isLogin()to return, taking the result ofisLogin()and iffalsethen returning anulljolokia url. This causes a dummy tree to be created and theJMXplugin to resolve satisfactorily.