-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): Initial Runtime plugin #556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test resultsRun attempt: 426
|
tadayosi
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. a few comments.
Fix showing active tab
… and sorting fix: fix sorting issues in the System Properties tab
mmelko
force-pushed
the
runtime-plugin
branch
2 times, most recently
from
September 19, 2023 20:43
d58dfa5
to
0b66d61
Compare
mmelko
force-pushed
the
runtime-plugin
branch
from
September 19, 2023 20:54
0b66d61
to
b4b7d1a
Compare
tadayosi
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some comments that are yet to be addressed.
tadayosi
reviewed
Sep 20, 2023
mmelko
force-pushed
the
runtime-plugin
branch
2 times, most recently
from
September 20, 2023 12:01
bec6b15
to
0a0d223
Compare
refactor threads and metrics to use jolokia scheduler instead of custom timeout use Record instead of Map in Metrics
mmelko
force-pushed
the
runtime-plugin
branch
from
September 20, 2023 12:42
0a0d223
to
5084938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Runtime plugin: with Properties, Metrics and Threads tabs: