Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): Initial Runtime plugin #556

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Sep 14, 2023

Adds Runtime plugin: with Properties, Metrics and Threads tabs:
image

image image image image

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Test Results

    8 files  ±0      8 suites  ±0   53m 6s ⏱️ + 2m 20s
  56 tests ±0    55 ✔️ ±0  1 💤 ±0  0 ±0 
444 runs  ±0  436 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit 5084938. ± Comparison against base commit 786e6e6.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Sep 14, 2023

Test results

Run attempt: 426
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(16)-java(11)-firefox 56 55 1 0 0 450.79
results-quarkus-node(16)-java(17)-firefox 56 55 1 0 0 434.69
results-quarkus-node(18)-java(11)-firefox 56 55 1 0 0 392.95
results-quarkus-node(18)-java(17)-firefox 56 55 1 0 0 378.517
results-springboot-node(16)-java(11)-firefox 55 54 1 0 0 357.562
results-springboot-node(16)-java(17)-firefox 55 54 1 0 0 391.345
results-springboot-node(18)-java(11)-firefox 55 54 1 0 0 406.206
results-springboot-node(18)-java(17)-firefox 55 54 1 0 0 374.743

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. a few comments.

packages/hawtio/src/plugins/runtime/Metrics.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/Metrics.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/Metrics.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/Metrics.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/Metrics.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/SysProps.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/Threads.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/index.ts Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/runtime-service.ts Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/runtime/Metrics.tsx Outdated Show resolved Hide resolved
@mmelko mmelko force-pushed the runtime-plugin branch 2 times, most recently from d58dfa5 to 0b66d61 Compare September 19, 2023 20:43
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some comments that are yet to be addressed.

@mmelko mmelko force-pushed the runtime-plugin branch 2 times, most recently from bec6b15 to 0a0d223 Compare September 20, 2023 12:01
refactor threads and metrics to use jolokia scheduler instead of custom timeout
use Record instead of Map in Metrics
@tadayosi tadayosi merged commit 47a68e1 into hawtio:main Sep 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants