feat: Further enhance the plugin header items extension point #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 8 files + 1 8 suites +1 52m 34s ⏱️ + 2m 22s For more details on these failures, see this check. Results for commit 722d77d. ± Comparison against base commit 03ea6c9. This pull request removes 4 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
phantomjinx
force-pushed
the
plugin-header
branch
2 times, most recently
from
b9ccb48
to
21f1e07
Compare
Test resultsRun attempt: 368
|
|
Tests seem to be all failing :-| |
tadayosi
reviewed
Sep 14, 2023
It's because of hawtio/hawtio#2937. Can you talk to @nstefeko @mmuzikar @jsolovjo to resolve the test failures as well? |
Hello, |
* core.ts * Some plugins require their header items to remain displayed on the header navbar, even though the plugin is not displayed, eg. when click 'connect' in hawtio-online with the discover plugin, a new window displays hawtio-app showing the connection JMX data. This new window still benefits from having the discover plugin dropdown list present so that other pods or console can be accessed without returing to the discover plugin. * Adds a 'universal' property to Plugin structure so that an individual plugin can state whether its header items should remain on the header toolbar even if the rest of the plugin is not the focused-on display * HawtioHeader.tsx * Find all header items that are either from the focused plugin or are marked as 'universal' to build the customized toolbar
phantomjinx
force-pushed
the
plugin-header
branch
from
21f1e07
to
722d77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.ts
header navbar, even though the plugin is not displayed, eg. when
click 'connect' in hawtio-online with the discover plugin, a new window
displays hawtio-app showing the connection JMX data. This new window
still benefits from having the discover plugin dropdown list present so
that other pods or console can be accessed without returing to the
discover plugin.
plugin can state whether its header items should remain on the header
toolbar even if the rest of the plugin is not the focused-on display
HawtioHeader.tsx
are marked as 'universal' to build the customized toolbar