Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write URL of the succeed requests to the sqlite database. #606

Closed

Conversation

literatesnow
Copy link

Thanks for oha! It's the perfect tool for the job.

This PR writes the URL (of successful requests) to the sqlite database. I'm using --rand-regex-url to make requests with a random correlation id that is propagated through the app and having the url in the sqlite db makes end to end tracing easy.

Suggestions on how to improve my rust are welcome.

@hatoo
Copy link
Owner

hatoo commented Nov 26, 2024

Sorry for the delayed response.
I was afraid of memory consumption. But I've realized that memory consumption would be minimal if we store random seed of each random-url instead of String and regenerate string when writing to SQLite. 64bit of random seed would be just enough.

I'll close PR because I want to handle this.
Thank you for your PR!

@hatoo hatoo closed this Nov 26, 2024
hatoo added a commit that referenced this pull request Nov 27, 2024
Re:  Write URL of the succeed requests to the sqlite database. #606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants