renesas: support micros with different number of HW pipes #2248
Conversation
not all renesas micro have the same number of pipes as expected by the find_pipe function for example see RA4M1 micro which only have 2 bulk pipes and 2 interrupt pipes for this reason some defines were introduced so that the actual number and positions of USB HW pipes can be defined at build time for different kind of processor using the ifndef ---> define mechanism allows to put sensible default values
|
sorry, I was busy with other works, will pull out datasheet and check this out soon enough. Thank you for your patient. |
There was a problem hiding this comment.
I just checked 4m1 group hw manual, it has the same pipe numbering as other i.e
- pipe 1,2: ISO + Bulk
- pipe 3,4,5 bulk only
- pipe 6-9 interrupt
So I guess this PR isn't needed ? Btw, I think we should rename PIPE_1ST_BULK since it isn't correct (first bulk is 1 though). But we could do that later on.
|
I am so sorry, I wrote the wrong micro. |
|
Hi! I am really sorry to bother you on this topic again. |
|
Sorry, was busy with other works. Will check this out as soon as I could |
There was a problem hiding this comment.
I just checked the manual for RA2A1, it indeed only support 5 pipes, oddly enough pipe0 then 4-7 (1-3 seems to be not usable). RA2A1 (and other similar mcus) should be detected e.g BSP_MCU_GROUP_RA2A1 and addressed by tinyusb without the need of using external MACRO as suggested change.
I don't have RA2A1 hardware on hand, but I can try to add an bsp for it, and then make some adjumst to pipe allocation for it later on.
PS: I have added ra2a1_ek board (not tested) #2317, hopefully that would help you to make further changes easier.
|
closed since a better approach is implemented by #2588 |
renesas: add support for renesas micro with different number of USB hw pipes
not all renesas micro have the same number of pipes as expected by the find_pipe function.
For example see RA4M1 micro which only have 2 bulk pipes and 2 interrupt pipes.
For this reason some defines were introduced so that the actual number and positions of USB HW pipes can be defined at build time for different kind of processor.
If you prefer a different approach please let me know. I will try to implement and test that on our arduino devices that uses renesas micro. Thanks
@facchinm