CLI: add an option for renew command fail on non-fullfillable request…

changelog/29060.txt

@@ -0,0 +1,3 @@
+```release-note:feature
+CLI: adds an optional flag (--fail-if-not-fullfilled) to the renew command, which lets the renew command fail on unfulfillable requests and allows command chaining to allow further executions.
+```

command/token_renew.go

@@ -21,8 +21,9 @@ var (
 type TokenRenewCommand struct {
 	*BaseCommand
 
-	flagAccessor  bool
-	flagIncrement time.Duration
+	flagAccessor            bool
+	flagIncrement           time.Duration
+	flagFailIfNotFullfilled bool
 }
 
 func (c *TokenRenewCommand) Synopsis() string {
@@ -86,6 +87,15 @@ func (c *TokenRenewCommand) Flags() *FlagSets {
 			"numeric string with suffix like \"30s\" or \"5m\".",
 	})
 
+	f.BoolVar(&BoolVar{
+		Name:       "fail-if-not-fullfilled",
+		Target:     &c.flagFailIfNotFullfilled,
+		Default:    false,
+		EnvVar:     "",
+		Completion: complete.PredictNothing,
+		Usage:      "Fail if the requested TTL increment cannot be fully fulfilled.",
+	})
+
 	return set
 }
 
@@ -140,5 +150,10 @@ func (c *TokenRenewCommand) Run(args []string) int {
 		return 2
 	}
 
+	if c.flagFailIfNotFullfilled && secret.LeaseDuration < int(increment.Seconds()) {
+		c.UI.Info("Token renewal failed: requested increment could not be fully fulfilled")
+		return 1
+	}
+
 	return OutputSecret(c.UI, secret)
 }

command/token_renew_test.go

@@ -31,30 +31,42 @@ func TestTokenRenewCommand_Run(t *testing.T) {
 		args []string
 		out  string
 		code int
+		fail bool
 	}{
 		{
 			"too_many_args",
 			[]string{"foo", "bar", "baz"},
 			"Too many arguments",
 			1,
+			false,
 		},
 		{
 			"default",
 			nil,
 			"",
 			0,
+			false,
 		},
 		{
 			"increment",
 			[]string{"-increment", "60s"},
 			"",
 			0,
+			false,
 		},
 		{
 			"increment_no_suffix",
 			[]string{"-increment", "60"},
 			"",
 			0,
+			false,
+		},
+		{
+			"fail_if_not_fullfilled",
+			[]string{"-increment", "30m", "--fail-if-not-fullfilled"},
+			"Token renewal failed: requested increment could not be fully fulfilled",
+			1,
+			true,
 		},
 	}
 
@@ -77,6 +89,10 @@ func TestTokenRenewCommand_Run(t *testing.T) {
 				ui, cmd := testTokenRenewCommand(t)
 				cmd.client = client
 
+				if tc.fail {
+					client.Auth().Token().Renew(token, 1)
+				}
+
 				code := cmd.Run(tc.args)
 				if code != tc.code {
 					t.Errorf("expected %d to be %d", code, tc.code)