Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make fmt #29053

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Run make fmt #29053

merged 1 commit into from
Nov 28, 2024

Conversation

victorr
Copy link
Contributor

@victorr victorr commented Nov 28, 2024

Description

Updates files after runnning make fmt

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@victorr victorr self-assigned this Nov 28, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 28, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

@victorr victorr marked this pull request as ready for review November 28, 2024 15:09
@victorr victorr requested review from a team as code owners November 28, 2024 15:09
@victorr victorr requested review from cinthiaconti and removed request for a team November 28, 2024 15:09
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@victorr victorr enabled auto-merge (squash) November 28, 2024 15:10
Copy link

Build Results:
All builds succeeded! ✅

@victorr victorr merged commit ba969bb into main Nov 28, 2024
100 of 108 checks passed
@victorr victorr deleted the victorr/make-fmt branch November 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants