feat: Add support for using jobspec2 parser #398
Conversation
|
|
alexdulin
force-pushed
the
feat/jobspec2-parser
branch
from
d41e846
to
546daf3
Compare
|
@jrasell Any chance this could get a review? Its been open for a while now and adds quite a bit of functionality and fixes to other issues people have been opening. Apologies in advance for @'ing you directly. |
There was a problem hiding this comment.
Thanks @alexdulin and apologies for the delay in reviewing. I mostly have a few questions that I would like your feedback on which are inline.
This adds in support for using the HCL2 jobspec2 parser with a new -hcl2 flag. This allows for using new features like `upstreams.datacenter` and terminating gateways. It should also allow for new features in the future to be used that are only being added to the new jobspec2 parser. Signed-off-by: Alex Dulin <alex@morningconsult.com>
alexdulin
force-pushed
the
feat/jobspec2-parser
branch
from
546daf3
to
a50f086
Compare
|
@jrasell addressed all your comments in initial review. Thanks! |
|
@tgross @jrasell I apologize for bugging you in advance, but is there any chance of this getting merged? All comments were addressed almost half a year ago and it would be great to get off of the fork of Levant we currently use, which is based on this branch. If this MR is not going anywhere, it would be greatly appreciated to know that so we can start implementing more long term solutions on our own. |
|
@alexdulin i'll put this on my list for early this week! |
|
Hello team it is 2022 and seems like this important PR is still in the review stage. |
|
@alexdulin and @bbarman4u yep my bad, this slipped through the gaps. I'll try and find some time to give this another look and test. |
|
I would be really interested in seeing this PR merged in as well 👍 |
|
Any chance this could get merged in? |
|
@jrasell Maybe we need to revisit this PR considering the HCLv1 deprecation in nomad v1.8.4 and the removable of HCLv1 support in nomad v1.9.0 |
This adds in support for using the HCL2 jobspec2 parser with a new -hcl2 flag.
This allows for using new features like
upstreams.datacenterand terminatinggateways. It should also allow for new features in the future to be used that
are only being added to the new jobspec2 parser.
Since using the jobspec2 parser and HCL2 can break existing job files, I decided to implement this as opt-in rather than opt-out, having the default be to use the original jobspec parser.
Signed-off-by: Alex Dulin alex@morningconsult.com