Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info about starting from bams #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add info about starting from bams #139

wants to merge 1 commit into from

Conversation

cademirch
Copy link
Collaborator

Adding some information about starting from BAMS and later GVCFS.

However, this currently wont work out of the box as the bam summary stats needs the fastp summary files.

The bandaid would be to comment out

out.extend(expand("results/{refGenome}/summary_stats/{prefix}_bam_sumstats.txt", refGenome=ref, prefix=config['final_prefix']))
, but this would likely break the QC stuff.

Probably best to add a flag for starting with BAMs that exludes the fastp summary from bam sumstats. Can think of a flag for GVCFs too. Appreciate thoughts here @tsackton and @erikenbody.

@tsackton
Copy link
Contributor

tsackton commented Nov 6, 2023

It looks like we use fastp just for reads passing filters? This seems probably not necessary; perhaps a better solution is to just remove the fastp dependence from sumstats.

@cademirch
Copy link
Collaborator Author

It looks like we use fastp just for reads passing filters? This seems probably not necessary; perhaps a better solution is to just remove the fastp dependence from sumstats.

Yeah we do. I agree with the fastp stats should be independent from the bam summary stats. Though it then brings up the question of what we do with the fastp stats? I guess they can be there for downstream analysis by the user if they are interested.

@tsackton
Copy link
Contributor

tsackton commented Nov 6, 2023

I don't think that we really need to analyze these stats. They may be useful for someone to look at if they, for example, see weird things in the mapping rates or something, but I've never actually looked at them....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants