Remove unnecessary availability check #3655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many years ago, we were occasionally finding that, when we uploaded WARCs to S3, they were not immediately available for download, even though the upload was completed. We added a retry to account for this.
Also many years ago, but more recently, Jack looked in to it and reported S3 has since changed, and this inconsistency isn't a problem any more. We decided to keep this check in the codebase anyway, because it was harmless.
Well, now it's causing trouble: we don't have WACZs when new upload-your-own archives are created, because we are still just making WARCs for those. So, the check fails.
Instead of tweaking the check to work properly in both situations, I'm just removing it.
If we find that S3 is, in fact, still inconsistent, then we can add a check back in.