test improvement for exception

handcraftedinthealps · Oct 6, 2023 · 48b8e3d · 48b8e3d
1 parent 2e303e0
commit 48b8e3d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/SearchEndpoint/KnnEndpoint.php b/src/SearchEndpoint/KnnEndpoint.php
@@ -31,7 +31,7 @@ public function add(BuilderInterface $builder, $key = null)
             return parent::add($builder, $key);
         }
 
-        throw new \LogicException('You need to add Knn builder!');
+        throw new \LogicException('Add Knn builder instead!');
     }
 
     /**

diff --git a/tests/Unit/SearchEndpoint/KnnEndpointTest.php b/tests/Unit/SearchEndpoint/KnnEndpointTest.php
@@ -12,6 +12,7 @@
 namespace ONGR\ElasticsearchDSL\Tests\Unit\SearchEndpoint;
 
 use ONGR\ElasticsearchDSL\Knn\Knn;
+use ONGR\ElasticsearchDSL\Query\MatchAllQuery;
 use ONGR\ElasticsearchDSL\SearchEndpoint\KnnEndpoint;
 use PHPUnit\Framework\TestCase;
 
@@ -45,6 +46,18 @@ public function testEndpointGetter(): void
         $this->assertSame($knn, $builders['knn']);
     }
 
+    /**
+     * Tests if endpoint returns builders.
+     */
+    public function testEndpointException(): void
+    {
+        $this->expectException(\LogicException::class);
+        $this->expectExceptionMessage('Add Knn builder instead!');
+        $knn = new MatchAllQuery();
+        $endpoint = new KnnEndpoint();
+        $endpoint->add($knn);
+    }
+
     /**
      * Tests if endpoint returns builders.
      */