Add ReturnTypeWillChange attributes (#26)

handcraftedinthealps · Mar 25, 2022 · 46b2a9d · 46b2a9d
1 parent b5ba2e3
commit 46b2a9d
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/Result/AbstractResultsIterator.php b/Result/AbstractResultsIterator.php
@@ -165,6 +165,7 @@ protected function getManager()
      *
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return $this->count;
@@ -175,6 +176,7 @@ public function count()
      *
      * @return mixed
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         return $this->getDocument($this->key());
@@ -183,6 +185,7 @@ public function current()
     /**
      * Move forward to next element.
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         $this->advanceKey();
@@ -193,6 +196,7 @@ public function next()
      *
      * @return mixed
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return $this->key;
@@ -203,6 +207,7 @@ public function key()
      *
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         if (!isset($this->documents)) {
@@ -222,6 +227,7 @@ public function valid()
     /**
      * Rewind the Iterator to the first element.
      */
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         $this->key = 0;

diff --git a/Result/Aggregation/AggregationValue.php b/Result/Aggregation/AggregationValue.php
@@ -115,6 +115,7 @@ public function find($path)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return array_key_exists($offset, $this->rawData);
@@ -123,6 +124,7 @@ public function offsetExists($offset)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         if (!isset($this->rawData[$offset])) {
@@ -135,6 +137,7 @@ public function offsetGet($offset)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         throw new \LogicException('Aggregation result can not be changed on runtime.');
@@ -143,6 +146,7 @@ public function offsetSet($offset, $value)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         throw new \LogicException('Aggregation result can not be changed on runtime.');

diff --git a/Result/ArrayIterator.php b/Result/ArrayIterator.php
@@ -19,6 +19,7 @@ class ArrayIterator extends AbstractResultsIterator implements \ArrayAccess
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return $this->documentExists($offset);
@@ -27,6 +28,7 @@ public function offsetExists($offset)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         return $this->getDocument($offset);
@@ -35,6 +37,7 @@ public function offsetGet($offset)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         $this->documents[$offset] = $value;
@@ -43,6 +46,7 @@ public function offsetSet($offset, $value)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         unset($this->documents[$offset]);

diff --git a/Service/Json/JsonReader.php b/Service/Json/JsonReader.php
@@ -190,6 +190,7 @@ protected function configureResolver(OptionsResolver $resolver)
      *
      * @return mixed
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         if ($this->currentLine === null) {
@@ -202,6 +203,7 @@ public function current()
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         $this->readLine();
@@ -212,6 +214,7 @@ public function next()
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return $this->key;
@@ -220,6 +223,7 @@ public function key()
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         return !feof($this->getFileHandler()) && $this->currentLine;
@@ -228,6 +232,7 @@ public function valid()
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         rewind($this->getFileHandler());
@@ -239,6 +244,7 @@ public function rewind()
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         $metadata = $this->getMetadata();