-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Batches UI Improvements #14640
[UI] Batches UI Improvements #14640
Conversation
@jmarshall curious for your thoughts on these example screenshots. Does this address your concerns from the original ticket? |
2cb6409
to
9fb463c
Compare
See the PR #14562 where Daniel introduced the new UI. He decided to use tailwind, which apparently (I don't know much about frontend stuff) prefers to keep styling in the html.
I like it.
In the template do we have the number of running jobs available? If so maybe we split "Pending" into "Pending" and "Running". Otherwise I think this is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all great changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this improves UI clarity. Nice change!
@@ -46,7 +46,7 @@ | |||
|
|||
{% call collapsible_li(true, 'Jobs', batch['n_jobs']) %} | |||
{{ kv_table({ | |||
'Pending': batch['n_jobs'] - batch['n_completed'], | |||
'Incomplete (Blocked, Queued or Running)': batch['n_jobs'] - batch['n_completed'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. To me, 'Pending' implies 'not running', so this improves clarity.
Screenshots should give the main overview of the changes
Questions for reviewers.
Technical:
UX:
Example: Batches page
(layout and columns)
Before:
After:
Example: Batch Details page
(Renaming confusing 'Pending' field)
Before:
After:
Fixes #14628. Adds and shuffles content on the new Batches table