Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] better error message when info array field has missing elements #14105

Merged
merged 9 commits into from
Jan 11, 2024

Commits on Dec 18, 2023

  1. [query] better error message when info array field has missing elements

    Fixes hail-is#13346.
    
    Another user was confused by this: hail-is#14102. Unfortunately, the world
    appears to have embraced missing values in VCF array fields even though the single element case is
    ambiguous. In hail-is#13346, I proposed a scheme by which we can disambiguate many of the cases, but implementing
    it ran into challenges because LoadVCF.scala does not expose whether or not an INFO field was a literal
    "." or elided entirely from that line.
    
    Anyway, this error message actually points users to the fix. I also changed some method names such that
    every method is ArrayType and never TypeArray.
    Dan King committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    39f72d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. fix doctest

    Dan King committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    4a57e41 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Merge hi/main into mitigate-13346

    Dan King committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    957de24 View commit details
    Browse the repository at this point in the history
  2. scalafmt

    Dan King committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    2732bc0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    588e212 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    93db761 View commit details
    Browse the repository at this point in the history
  5. fix import_vcf doc example

    Dan King committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    743cfd8 View commit details
    Browse the repository at this point in the history
  6. Update test_impex.py

    danking authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    2677f14 View commit details
    Browse the repository at this point in the history
  7. reformat table

    Dan King committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c4d307b View commit details
    Browse the repository at this point in the history