-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] better error message when info array field has missing elements #14105
Merged
Commits on Dec 18, 2023
-
[query] better error message when info array field has missing elements
Fixes hail-is#13346. Another user was confused by this: hail-is#14102. Unfortunately, the world appears to have embraced missing values in VCF array fields even though the single element case is ambiguous. In hail-is#13346, I proposed a scheme by which we can disambiguate many of the cases, but implementing it ran into challenges because LoadVCF.scala does not expose whether or not an INFO field was a literal "." or elided entirely from that line. Anyway, this error message actually points users to the fix. I also changed some method names such that every method is ArrayType and never TypeArray.
Dan King committedDec 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 39f72d7 - Browse repository at this point
Copy the full SHA 39f72d7View commit details
Commits on Dec 19, 2023
-
Dan King committed
Dec 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 4a57e41 - Browse repository at this point
Copy the full SHA 4a57e41View commit details
Commits on Jan 9, 2024
-
Merge hi/main into mitigate-13346
Dan King committedJan 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 957de24 - Browse repository at this point
Copy the full SHA 957de24View commit details -
Dan King committed
Jan 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 2732bc0 - Browse repository at this point
Copy the full SHA 2732bc0View commit details -
Merge remote-tracking branch 'hi/main' into mitigate-13346
Dan King committedJan 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 588e212 - Browse repository at this point
Copy the full SHA 588e212View commit details -
fix test broken by merge conflict and add missing VCF for docs tests
Dan King committedJan 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 93db761 - Browse repository at this point
Copy the full SHA 93db761View commit details -
Dan King committed
Jan 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 743cfd8 - Browse repository at this point
Copy the full SHA 743cfd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2677f14 - Browse repository at this point
Copy the full SHA 2677f14View commit details -
Dan King committed
Jan 9, 2024 Configuration menu - View commit details
-
Copy full SHA for c4d307b - Browse repository at this point
Copy the full SHA c4d307bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.