Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already the default behavior of the
zstd
crate, but this feature allows the following:With a Cargo.toml like this, the default behavior would by dynamic linking for both openssl and zstd, and a static binary could be built with:
At the moment, the Cargo.toml would need to be written like this:
And built like this:
I also made sure that, even with the
vendored
feature set, one could still opt into dynamic linking with:The options take precedence in this order (lowest to highest):
pkg-config
(dynamically linked)vendored
(vendored)ZSTD_SYS_USE_PKG_CONFIG=1
(dynamically linked)Thanks!